DX-1128: localise Code + CodeSnippet (completes the visual lift)#3416
Open
jamiehenson wants to merge 1 commit into
Open
DX-1128: localise Code + CodeSnippet (completes the visual lift)#3416jamiehenson wants to merge 1 commit into
jamiehenson wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
f0aa029 to
712dec4
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
17d25cb to
2da466a
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
712dec4 to
2218333
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
2da466a to
6dff760
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
2218333 to
2f0072c
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
6dff760 to
c1b3585
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
2f0072c to
b67f0f1
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
c1b3585 to
0dd3b59
Compare
This was referenced Jun 18, 2026
Merged
Merged
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
b67f0f1 to
f97a86b
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
0dd3b59 to
edfcd5c
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
f97a86b to
adf4d03
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
edfcd5c to
2886121
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
adf4d03 to
b7e67be
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
2886121 to
58cbfa2
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
58cbfa2 to
cf1a310
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
96e2ff3 to
a1cbcb6
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
cf1a310 to
a89f164
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
a89f164 to
988717a
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
a1cbcb6 to
f2b8c6b
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
f2b8c6b to
040b28a
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
988717a to
02983c0
Compare
jamiehenson
force-pushed
the
dx-1128/docs-syntax-highlighter
branch
from
040b28a to
7b0ecb0
Compare
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
02983c0 to
776d25f
Compare
Member
Author
|
Where these are used (review aid):
~ 𝒞𝓁𝒶𝓊𝒹𝑒 |
…+ drop @ably/ui Tailwind scan (DX-1128) Vendor Code and CodeSnippet (with ApiKeySelector, LanguageSelector, CopyButton, PlainCodeView, Tooltip) locally, off @ably/ui/core, completing the visual lift. Their internal Heroicon usages now import the components directly from @heroicons/react rather than routing names through the glyphs-only local Icon, and PlainCodeView's icon prop takes a ReactNode. Also prunes dead vendored CSS and drops the @ably/ui path from the Tailwind content scan.
jamiehenson
force-pushed
the
dx-1128/docs-codesnippet
branch
from
776d25f to
5709946
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DX-1128. Final PR — localises
Code+CodeSnippet(the last@ably/uivisual surface), then applies the end-state cleanup.What
Code,CodeSnippet(+ApiKeySelector,CopyButton,LanguageSelector,PlainCodeView,TooltipButton,languages) and the transitiveTooltipintosrc/components/ui/.MDXWrapperrewired; the SessionData seam stays (apiKeys passed as a prop). The subcomponents' internal Heroicon usages are imported directly from@heroicons/react(with the right outline/solid/micro variants), andPlainCodeView'siconprop takes aReactNode.node_modules/@ably/uiTailwind content glob, deletes the 5 dead vendored CSS files (legacy-buttons, dropdowns, layout, Slider, Flash), prunesshadows→ the 2 used tokens andforms→ the checkbox block. Compiledglobal.css8.4k → 6.7k lines.After this PR
docs' entire visual surface is local. Remaining
@ably/uiimports =insights(×6) +scripts(×2 — theSessionDataProvider/useSessionDatacontext API); the old SessionData Redux store +Flashreducer are gone after rebasing onto the 18.3.1main(Ken's #3418 migration) — parked infra, not design-system.Stack (DX-1128)
@ably/uitokens + reset/core CSS (merged)cn+heightsutilsIconcomponent (Ably glyphs only; Heroicons imported directly)@ably/uiTailwind scan#3410–#3416 are a linear stack, each building on the previous; #3409 has merged to
main. ▶ = this PR.Testing
🤖 Generated with Claude Code